Re: [PATCH] common/btrfs: source module file

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Nov 05, 2021 at 01:32:11PM +0200, Nikolay Borisov wrote:
> 
> 
> On 5.11.21 г. 13:04, Filipe Manana wrote:
> > On Thu, Nov 4, 2021 at 8:40 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
> >>
> >> btrfs/249 fails with:
> >>
> >> QA output created by 249
> >> ./common/btrfs: line 425: _require_loadable_fs_module: command not found
> >> ./common/btrfs: line 432: _reload_fs_module: command not found
> >> ERROR: not a btrfs filesystem: /media/scratch
> >>
> >> Fix this by sourcing common/module in the btrfs common file.
> > 
> > I'm not sure why you get such a failure. Without the relevant
> > btrfs-progs and btrfs kernel patches, I don't get that error:
> 
> I checked all these tests and btrfs/248 and btrfs/249 do not import
> common/module whilst the others do it so this might be one of the reason.

Odd btrfs/248 runs fine here.

> IMO it would be cleaner to source it in common/btrfs to remove the
> duplication.

Sure that works with me. Will send a v2.

  Luis



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux