On 10/21/18 11:15 PM, Dave Chinner wrote: > On Sun, Oct 21, 2018 at 10:09:01PM -0500, Jayashree Mohan wrote: >> On Sun, Oct 21, 2018 at 9:44 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>> >>>>> >>>>>> See the file xfstests-dev/tests/generic/group to see how groups get >>>>>> assigned to tests. I suppose all of the crashmonkey tests should be >>>>>> assigned to a new group, say, "crashmonkey". >>> >>> Wait, let me get it straight. Did crashmonkey produce 300 test cases or >>> did it find 300 bugs? Are all those test cases passing on all filesystems? >>> Some test cases failing on some filesystems? >> >> CrashMonkey generates 300 workloads, out of which 3 tests result in >> bugs in two file systems (btrfs and F2FS). Others passed clean for >> ext4, xfs, btrfs and F2FS. Given that xfstest is a regression test >> suite, we thought it would be beneficial to add all 300 workloads to >> the generic test - > > Perhaps you should port a test or two so we can have a look at what > these tests are before we make any recomendations on the best way to > integrate them. 300 new tests is an awful lot to maintain if we ever > want to change anything.... I agree with this, do a couple and let people take a look. -Eric
