Hi Akira, On 01/29/2013 03:22 AM, Akira TAGOH wrote: > Please make the modified code MT-safety and good to attach the patch as > the file or into the bugzilla next time. Attached a v2 patch to bug #59456. Thanks, Laurentiu > > Thanks, > > > On Mon, Jan 28, 2013 at 9:20 PM, Laurentiu Palcu > <laurentiu.palcu@xxxxxxxxx <mailto:laurentiu.palcu@xxxxxxxxx>> wrote: > > Hi all, > > > This patch will add a --sysroot option to fc-cache and fc-cat tools. > More > explanations have been included in the commit message of the patch > itself. > > Please review the patch but bear in mind that I only took contact > with fontconfig > source code approx a week ago. So, even though I tried my best to > respect the > coding convention and existing API, there are things I might have > missed. > > I tested the patch both locally and on target. That is, after I > deployed the image, > I re-run fc-cache (without sysroot) and saw that the generated cache > was identical. > > I also ran the tools under valgrind and, apparently, there were no > leaks introduced. > > I sent the changes within only one patch as it adds only one logical > change. But, if > you guys have other rules (one patch per file, etc.), let me know > and I'll resend. > > That being said, please review/test the changes yourselves and let > me know your > concerns/thoughts/etc. > > Thanks, > Laurentiu > > Laurentiu Palcu (1): > Add sysroot option to fc-cache and fc-cat > > fc-cache/fc-cache.c | 57 ++++++++++++++++++----- > fc-cat/fc-cat.c | 54 +++++++++++++++++---- > fontconfig/fontconfig.h | 6 +++ > src/fccache.c | 119 > ++++++++++++++++++++++++++++++++++++++++------- > src/fccfg.c | 32 +++++++++++++ > src/fcfreetype.c | 4 ++ > src/fcstr.c | 18 ++++++- > 7 files changed, 251 insertions(+), 39 deletions(-) > > -- > 1.7.9.5 > > _______________________________________________ > Fontconfig mailing list > Fontconfig@xxxxxxxxxxxxxxxxxxxxx > <mailto:Fontconfig@xxxxxxxxxxxxxxxxxxxxx> > http://lists.freedesktop.org/mailman/listinfo/fontconfig > > > > > -- > Akira TAGOH _______________________________________________ Fontconfig mailing list Fontconfig@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/fontconfig
