Re: [PATCH] fio: add nvme fdp support for io_uring_cmd engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 09, 2023 at 09:59:00AM +0900, Damien Le Moal wrote:
> On 2/9/23 07:20, Keith Busch wrote:
> 
> > diff --git a/io_u.h b/io_u.h
> > index 206e24fe..13b26d37 100644
> > --- a/io_u.h
> > +++ b/io_u.h
> > @@ -117,6 +117,9 @@ struct io_u {
> >  	 */
> >  	int (*end_io)(struct thread_data *, struct io_u **);
> >  
> > +	uint32_t dtype;
> > +	uint32_t dspec;
> 
> Nit: may be call these fdp_dtype and fdp_dspec to clarify these are for fdp ?

These could also be used for stream ids since they occupy the same space in an
nvme command, so the generic name sounded "ok". But perhaps no one cares about
such use cases...



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux