On Thu, Feb 09, 2023 at 03:05:53PM +0530, Ankit Kumar wrote: > Hey Keith, > > Sorry for delaying this. It's no problem. This one targets io_uring_cmd ioengine rather than xnvme, so this merely overlaps with your pending changes. > I recently added a few more checks inside fdp_support, and a way to > get reclaim unit size for the current fdp configuration. I'm actually wondering what the point of the checks are. If fdp isn't supported it'll fail the io-mgmt-recv, which is as good a check as any. The identify and directives checks are just redundant and make up the bulk of the patch size. Let's just get rid of it? > The reclaim unit size will come in handy as we improve the fdp section of FIO. > I also figured a way to fetch all the available reclaim unit handle > descriptors instead of 1024. Nice. > Hope its ok, if I send a v2 on top of this and you can look at it. I > am not sure how much the fdp specific section of code > has diverged as those were missing here (fdp.c and fdp.h). Oops, my mistake. I'll send that out shortly.
