On 2/9/23 09:59, Damien Le Moal wrote:
> On 2/9/23 07:20, Keith Busch wrote:
>> From: Keith Busch <kbusch@xxxxxxxxxx>
>>
>> NVMe TP4146 creates a new feature called Flexible Data Placement. This
>> feature allows a host to tell the device how to group write data through
>> the use of "Placement Identifiers" in write commands.
>>
>> Add support for using placement identifiers in write commands. The user
>> can enabled this with the new "fdp=1" parameter for fio's io_uring_cmd
>> ioengine. By default, the fio jobs will cycle through all the namespace's
>> available placement identifiers for write commands. The user can limit
>> which placement identifiers can be used with additional parameter,
>> "fdp_plis=<list,>", which can be used to separate write intensive jobs
>> from less intenstive ones.
>>
>> Setting up your namespace for FDP is outside the scope of 'fio', so this
>> assumes the namespace is already properly configured for the mode.
>>
>> Based-on-a-patch-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx>
>> Signed-off-by: Keith Busch <kbusch@xxxxxxxxxx>
>
> [...]
>> diff --git a/file.h b/file.h
>> index da1b8947..deb36e02 100644
>> --- a/file.h
>> +++ b/file.h
>> @@ -12,6 +12,7 @@
>>
>> /* Forward declarations */
>> struct zoned_block_device_info;
>> +struct fdp_ruh_info;
>>
>> /*
>> * The type of object we are working on
>> @@ -101,6 +102,8 @@ struct fio_file {
>> uint64_t file_offset;
>> uint64_t io_size;
>>
>> + struct fio_ruhs_info *ruhs_info;
>
> white line before declaration can be removed I think.
My bad. This is not a function :)
--
Damien Le Moal
Western Digital Research
