On 7/17/18 3:38 PM, Jeff Furlong wrote: >> I'd just convert those helpers to deal with unsigned long long always, that should work fine for the uint case. > Done. I tested with: > > # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bssplit=4g/100 --filename=/dev/nvme1n1 --number_ios=2 > > Here's the final patch unless someone finds an issue. I also updated > it so it applies nicely to the latest on git. Tested with bs, ba, > bsrange, bssplit options that have a >32 bit value. Looks pretty good to me, I applied it with various little fixups in terms of style. Please test current -git and ensure that it works properly for you. Ran some basic testing here, and it still seems good. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html