> -----Original Message----- > From: fio-owner@xxxxxxxxxxxxxxx [mailto:fio-owner@xxxxxxxxxxxxxxx] On Behalf Of Jeff Furlong > Sent: Thursday, July 12, 2018 5:14 PM > To: Jens Axboe <axboe@xxxxxxxxx>; fio@xxxxxxxxxxxxxxx > Subject: RE: fio max blocksize ... > diff --git a/cconv.c b/cconv.c > index bfd699d..9180bac 100644 > --- a/cconv.c > +++ b/cconv.c > @@ -110,16 +110,16 @@ void convert_thread_options_to_cpu(struct thread_options *o, > o->start_offset_percent = le32_to_cpu(top->start_offset_percent); > > for (i = 0; i < DDIR_RWDIR_CNT; i++) { > - o->bs[i] = le32_to_cpu(top->bs[i]); > - o->ba[i] = le32_to_cpu(top->ba[i]); > - o->min_bs[i] = le32_to_cpu(top->min_bs[i]); > - o->max_bs[i] = le32_to_cpu(top->max_bs[i]); > + o->bs[i] = le64_to_cpu(top->bs[i]); > + o->ba[i] = le64_to_cpu(top->ba[i]); > + o->min_bs[i] = le64_to_cpu(top->min_bs[i]); > + o->max_bs[i] = le64_to_cpu(top->max_bs[i]); > o->bssplit_nr[i] = le32_to_cpu(top->bssplit_nr[i]); That implies an interoperability issue in client/server mode - a new client could generate values that an old server couldn't parse. Update FIO_SERVER_VER to require them to be compatible versions. --- Robert Elliott, HPE Persistent Memory ��.n��������+%������w��{.n�������^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
