RE: [PATCH] idle-prof: append output cpu idleness data to terse log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Alireza Haghdoost <haghdoost@xxxxxxxxx>
> Sent: Tuesday, July 17, 2018 2:25 PM
> To: Sitsofe Wheeler <sitsofe@xxxxxxxxx>
> Cc: Elliott, Robert (Persistent Memory) <elliott@xxxxxxx>;
> Friendy.Su@xxxxxxxx; fio@xxxxxxxxxxxxxxx; No.Tanaka@xxxxxxxx;
> Hajime.Tomura@xxxxxxxx
> Subject: Re: [PATCH] idle-prof: append output cpu idleness data to
> terse log
> 
> On Tue, Jul 17, 2018 at 2:13 PM, Sitsofe Wheeler <sitsofe@xxxxxxxxx> wrote:
> >
> > On 17 July 2018 at 15:30, Alireza Haghdoost <haghdoost@xxxxxxxxx> wrote:
> > > On Tue, Jul 17, 2018 at 9:18 AM, Elliott, Robert (Persistent Memory) ...
> > >> Since the terse format is not self-describing, new fields require
> > >> a version bump (see -terse-version).
> > >>
> > >> Maybe one of the versions should print out the field names as the first
> > >> line, so it becomes self-describing.  I guess the json format already
> > >> provides that functionality, so it might not be necessary.
> > >>
> > > How about adding an extra command option like --terse-header that
> > > prints out the header only? It is hard to keep track of these version
> > > changes in one place at the user manual or some blog post.
> > > with a terse header command option, I can ignore the terse version and
> > > adjust my test scripts to query the header first before running the
> > > test, then pull the right column after the test finishes.
> >
> > You would then need to document all the terse formats because you
> > never know which one someone will use (it looks like there are four:
> > http://fio.readthedocs.io/en/latest/fio_doc.html#cmdoption-terse-version
> > ). At this stage shouldn't we be nudging people towards JSON which is
> > more self describing and easier to extend in a backwards compatible
> > manner?
> 
> I am on board with your suggestion but not every user might have a
> time/resource to re-implement their existing test script to work with
> json. We should stop adding more versions of the terse. Otherwise, If
> we want to continue supporting the terse format, I recommend to
> figure out a programmatic way to handle its complexity.

How about defining that the next terse version always includes
a header line, so it'll be self-describing and can be the final
terse version.


---
Robert Elliott, HPE Persistent Memory


��.n��������+%������w��{.n�������^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux