On 17 July 2018 at 15:30, Alireza Haghdoost <haghdoost@xxxxxxxxx> wrote: > On Tue, Jul 17, 2018 at 9:18 AM, Elliott, Robert (Persistent Memory) > <elliott@xxxxxxx> wrote: >> >> >>> -----Original Message----- >>> From: fio-owner@xxxxxxxxxxxxxxx <fio-owner@xxxxxxxxxxxxxxx> On Behalf >>> Of Friendy.Su@xxxxxxxx >>> Sent: Tuesday, July 17, 2018 2:46 AM >>> To: fio@xxxxxxxxxxxxxxx >>> Cc: No.Tanaka@xxxxxxxx; Hajime.Tomura@xxxxxxxx; Friendy.Su@xxxxxxxx >>> Subject: [PATCH] idle-prof: append output cpu idleness data to terse >>> log >>> >>> cpu idleness data only output to normal and json log, >>> also output to terse log. >>> >>> Signed-off-by: friendy-su <friendy.su@xxxxxxxx> >>> --- >>> HOWTO | 4 +++- >>> idletime.c | 19 +++++++++++++++++++ >>> stat.c | 2 ++ >>> 3 files changed, 24 insertions(+), 1 deletion(-) >>> >>> diff --git a/HOWTO b/HOWTO >>> index 70eed280..497e8cb1 100644 >>> --- a/HOWTO >>> +++ b/HOWTO >>> @@ -3564,8 +3564,10 @@ will be a disk utilization section. >>> Below is a single line containing short names for each of the fields >>> in the >>> minimal output v3, separated by semicolons:: >>> >>> - >>> terse_version_3;fio_version;jobname;groupid;error;read_kb;read_bandwi >> ... >>> + >>> terse_version_3;fio_version;jobname;groupid;error;read_kb;read_bandwi >> ... >> >> Since the terse format is not self-describing, new fields require >> a version bump (see -terse-version). >> >> Maybe one of the versions should print out the field names as the first >> line, so it becomes self-describing. I guess the json format already >> provides that functionality, so it might not be necessary. >> > How about adding an extra command option like --terse-header that > prints out the header only? It is hard to keep track of these version > changes in one place at the user manual or some blog post. > with a terse header command option, I can ignore the terse version and > adjust my test scripts to query the header first before running the > test, then pull the right column after the test finishes. You would then need to document all the terse formats because you never know which one someone will use (it looks like there are four: http://fio.readthedocs.io/en/latest/fio_doc.html#cmdoption-terse-version ). At this stage shouldn't we be nudging people towards JSON which is more self describing and easier to extend in a backwards compatible manner? -- Sitsofe | http://sucs.org/~sits/ -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
