On Mon, Sep 02 2013, Erwan Velu wrote: > On 31/08/2013 06:31, Jens Axboe wrote: > >[...] > >Agree. A good commit message describes the need for the change. It needs > >to justify its own inclusion, so to speak. Basically it answers the key > >question of why this change is needed. > > > > I don't know how you play with fio, but on my project I'm working on, that's > a good reason to refuse a patch even if the code is correct :o) I tend to be (too) nice and provide the missing commit log, especially if it's for a feature and needs a description. But I have been known to push back as well and just ask for a description. Usually has not been a problem. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
