On Wed, Aug 28 2013, Erwan Velu wrote: > On 27/08/2013 00:11, Grant Grundler wrote: > >Jens, et al, > > > >In general I'm ok with this patch...just one issue I'd like to get an > >opinion on... > > > I don't have the skill to make a technical review of it. > > At least, I'm a great fan of well detailed commits. > At my taste, I do like when a commit does explain what was the problem and > what is the solution. > > A single line for such commit seems a little bit light for me. Agree. A good commit message describes the need for the change. It needs to justify its own inclusion, so to speak. Basically it answers the key question of why this change is needed. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
