On 31/08/2013 06:31, Jens Axboe wrote:
[...] Agree. A good commit message describes the need for the change. It needs to justify its own inclusion, so to speak. Basically it answers the key question of why this change is needed.
I don't know how you play with fio, but on my project I'm working on, that's a good reason to refuse a patch even if the code is correct :o)
Cheers, Erwan -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html