Gagadget wrote: > Thank you, here is what I did : > > %define VERSION 9.6.0 > %define PATCHVER 1 > %define DISTVER mylocaldist > %define PKGVER 1 > [...] > Version: %{VERSION} Since you are not using the "-" in the version, you can remove the %define VERSION 9.6.0 and just use: Version: 9.6.0 Then future references to version will be %{version} > Release: %{?PATCHVER:P%PATCHVER.}%{DISTVER}.%{PKGVER} > [...] > Source0: > ftp://ftp.isc.org/isc/bind9/%{VERSION}%{?PATCHVER:-P%PATCHVER}/bind-%{VERSION}%{?PATCHVER:-P%PATCHVER}.tar.gz > [...] > %prep > %setup -q -n %{name}-%{VERSION}%{?PATCHVER:-P%PATCHVER} > > I can't define a BINDVER or XVER because I want to have the Patchlevel > in the Release tag, and it refuse the "-". With the above, my rpm is > named bind-9.6.0-P1.mylocaldist.1 > > One question : > > If i do > # %define PATCHVER 1 > > The PATCHVER is still define, I have to delete it to get it work ??? Is > it normal ? > Yes. macros are expanded even in comments. You can do this instead: # %%define PATCHVER 1 -Toshio -- Fedora-packaging mailing list Fedora-packaging@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-packaging