Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472792 --- Comment #2 from Conrad Meyer <konrad@xxxxxxxxxx> 2008-12-17 07:49:57 EDT --- Created an attachment (id=327246) --> (https://bugzilla.redhat.com/attachment.cgi?id=327246) [Review] Attached is my initial review. Thanks for submitting this software to Fedora! General comments: - Why the %update_maven_depmap and friends? It uses ant to build, not maven (note: I don't think this is wrong necessarily, I'm just unfamiliar with maven and would like to understand if this should be part of the java packaging guidelines for ant-built packages as well as maven). Will approve as soon as "BAD" marked thing is either fixed or explained. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review