Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465943 --- Comment #12 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> 2008-12-17 07:49:19 EDT --- (In reply to comment #11) > A few fixes required. Also as a side note it doesn't look like libgnome is used > in the source files but its included in the configure checks but I'm not sure. I've added a patch to remove it from configure.in. Well spotted. > + rpmlint output > > $ rpmlint NetworkManager-openconnect.spec > NetworkManager-openconnect.spec: W: mixed-use-of-spaces-and-tabs (spaces: line > 1, tab: line 70) Fixed. > - license matches the actual package license > > There's no COPYING file included in the source. Some of the source files > include the license but some don't include any at all. Added COPYING file in a patch also. Will push upstream. > - upstream sources match sources in the srpm > 399dc23f2df67d994770dfdfdaec0ecb > NetworkManager-openconnect-0.7.0.svn3.tar.gz > > Package needs to adhere to source requirements, if its using VCS snapshots it > needs to be specified as per the Packaging docs. > https://fedoraproject.org/wiki/Packaging/SourceURL Added instructions. > - BuildRequires list all build dependencies > > Not sure why libpng is required. It builds fine without it and doesn't seem to > check for it in the configure script. Removed. > - package owns all directories it creates > > /usr/share/gnome-vpn-properties/openconnect/ is not owned by the package Fixed. > /usr/share/gnome-vpn-properties/ isn't either and should probably be owned by > NetworkManager itself as more than one NM vpn package installs things there. Yeah, that's a NetworkManager bug. > - %install must start with rm -rf $RPM_BUILD_ROOT etc. > needs to remove old buildroots Fixed. Spec URL: http://david.woodhou.se/NetworkManager-openconnect.spec SRPM URL: http://david.woodhou.se/NetworkManager-openconnect-0.7.0-2.svn3.fc10.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1003330 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review