Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473972 --- Comment #10 from Dan Horák <dan@xxxxxxxx> 2008-12-17 07:50:59 EDT --- (In reply to comment #9) > Hi, > > I have fixed all the Warning and Errors (i do rpmlint on each packages). Just > two things : > > - libnuclient.x86_64: W: shared-lib-calls-exit /usr/lib64/libnuclient.so.3.0.0 > exit@xxxxxxxxxxx <- it's only when we have a "violent" error > OK > - I have submitted the patch upstream, but haven't add the link in specfile > because i post the ticket in the private bugtracker. The patch will be added to > the next release. > OK there are still few little issues - the ldconfig calls in the scriptlets for the main package are useless (the libnuclient package already has them) - I would prefer when the /etc/sysconfig/nufw file is added as new SourceX: instead of online creation in the %install section - mixed-use-of-spaces-and-tabs in the spec (spaces: line 244, tab: line 3) - BuildRequires: python for the python-nufw package is redundant (this dependency is auto-solved via python-devel) - the DefaultStop line in the initscripts should contain all levels 0 - 6 to complement DefaultStart - multiple packages own the %{_sysconfdir}/nufw/ directory - that depends on the exact interaction between the packages - must be the nuauth service run on the same machine as nufw? - does have sense to have only the nufw-utils or nutcpc packages installed (without nufw)? - are the files in %{_sysconfdir}/nufw/ properly separated between nufw and nuauth? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review