Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #3 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-11-10 14:11:06 EDT --- Just some quick comments on your spec file: - iconv -f ISO-8859-1 -t UTF-8 %{_builddir}/%{name}-%{version}/AUTHORS -o \ %{_builddir}/%{name}-%{version}/AUTHORS You didn't preserve the time stamp https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps - desktop-file-install --vendor="fedora" Vendor tag 'fedora' is no longer used, see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor - gzip $RPM_BUILD_ROOT/%{_mandir}/man1/links.1 This is not necessary, install only the non-gzipped man page (as links.1), it is compressed automatically during rpm build process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review