Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469273 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #16 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-11-10 13:36:30 EDT --- For -5: (In reply to comment #11) > For 1.12.4-3: > * Compiler flags > - Fedora uses "-O2" compiler flags (, which can be checked by > $ rpm --eval %optflags ), which is replaced by the latter "-O0", > which needs fixing. - This issue is not yet fixed. This can be fixed by ------------------------------------------------ %prep %setup -q -n quickfix %patch0 -p1 %patch1 -p1 sed -i.flags -e 's|-O0 -g||' src/C++/test/Makefile.in %build %configure --enable-shared ...... ------------------------------------------------ * Requires - Now "BuildRequires: boost-devel" is added, HAVE_BOOST_FAST_POOL_ALLOCATOR is defined on config.h and this affects installed config.h (however see below: usually config.h must not be installed) So now quickfix-devel should have "Requires: boost-devel", too * Excluding .la files - I prefer to use ------------------------------------------------ rm -f $RPM_BUILD_ROOT%{_libdir}/*.la ------------------------------------------------ instead of using %exclude in this case. - Anyway if you use %exclude, please write this line after %defattr(-,root,root,-) line (otherwise rpmlint complains) * autotool generated header files inclusion - -devel subpackage installs autotool generated "config.h" as a header file. This must be avoid, because shipping "config.h" will easily cause namespace conflict when compiling codes with quickfix-devel: c.f. bug 208034 comment 43 A quick workaround can be: - rename installed "config.h" to "quickfix-config.h" - and the line #include "config.h" in installed Utility.h to "#include "quickfix-config.h"". Then: ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose "Merge Review") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review