[Bug 455953] Review Request: rakarrack - Audio effects processing rack for guitar

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455953





--- Comment #15 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx>  2008-10-15 15:02:16 EDT ---
(In reply to comment #14)

*
> (In reply to comment #11)
> > * rakarrack.desktop -> %{name}.desktop
> I looked at it and thought, maybe I should assign a variable to store the
> complete path to .desktop in. Do people normally do things like that ?
> 

I don't think you need that. The way it is is fine.

*
> In the end I still had to manually move the files to the doc-versioned dir so
> that rpm and the app finds these things as expected.
> It seems that this is an issue with some part of the source, ie the passed
> --docdir and --htmldir are not properly used during configure, make and
> install.
> I am not sure what causes the html+COPYING files to end up in a non-versioned
> doc dir, otherwise I would send a patch upstream.

Yes I noticed that. The problem is in the docdir definitions in doc/Makefile.am
and doc/Makefile.in files. But sed'ding them is not recommended because then
you will need to run autoconf tools which might result in different
configure&Makefiles depending on the autoconf version.

I think your workaround (moving the files manually) is just fine until a fix
comes from upstream.  

The variable HELPDIR should normally pick up the --htmldir flag you pass to
configure. But for some reason they put a hardcoded path for HELPDIR which
confused us in the beginning. But make sure you let the upstream know about
these problems.

*
> 
> Updated spec: http://members.iinet.net.au/~timmsy/rakarrack/rakarrack.spec
> New .src.rpm:
> http://members.iinet.net.au/~timmsy/rakarrack/rakarrack-0.2.0-4.fc9.src.rpm
> 
> - move non-install commands to setup
> - fix configure .ini so that standard help path will be used

Great. Last remarks:

* You won't need this line twice. Once (before %configure) is just fine:
   %{__sed} -i
's|HELPDIR="$prefix/share/doc/${PACKAGE}"|HELPDIR="$prefix/share/doc/${PACKAGE}-%{version}"|'
configure.in

* When submitting your final version, make sure you remove the commands you
commented out that are not relevant. For instance:
   #echo aftt:======

* Careful! :
     #%%{_datadir}/doc/%{name}/COPYING
-->  #%%{_datadir}/doc/%%{name}/COPYING
Well you will need to completely remove this line anyways. But keep in mind
that having a macro in a comment with a single % is enough reason to not
approve a package. I know the rules are very strict but it is those rules that
make fedora consistent. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]