Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455953 --- Comment #16 from David Timms <dtimms@xxxxxxxxxxxx> 2008-10-15 17:41:36 EDT --- (In reply to comment #15) > The variable HELPDIR should normally pick up the --htmldir flag you pass to > configure. But for some reason they put a hardcoded path for HELPDIR which > confused us in the beginning. But make sure you let the upstream know about > these problems. Will do. > * You won't need this line twice. Once (before %configure) is just fine: > %{__sed} -i > 's|HELPDIR="$prefix/share/doc/${PACKAGE}"|HELPDIR="$prefix/share/doc/${PACKAGE}-%{version}"|' configure.in In trying to get html/helpdir to work, I thought the sed changes may have been failing, or overwritten before the make. Unfortunately I left my debug cruft in the spec ;-|, now gone. > * When submitting your final version, make sure you remove the commands you > commented out that are not relevant. For instance: done. it was getting late, and I was keen to have something published so that my progress could be reviewed. > * Careful! : > #%%{_datadir}/doc/%{name}/COPYING > --> #%%{_datadir}/doc/%%{name}/COPYING > Well you will need to completely remove this line anyways. But keep in mind > that having a macro in a comment with a single % is enough reason to not > approve a package. I know the rules are very strict but it is those rules that > make fedora consistent. :) Did it again :(. Actually, this check could possibly be performed by rpmlint -> fail bad specs. I'll take that up with it's upstream. Updated spec: http://members.iinet.net.au/~timmsy/rakarrack/rakarrack.spec New .src.rpm: http://members.iinet.net.au/~timmsy/rakarrack/rakarrack-0.2.0-5.fc9.src.rpm - del debug cruft left in the spec while trying to solve issues -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review