Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458784 --- Comment #8 from Patrice Dumas <pertusus@xxxxxxx> 2008-10-10 18:18:37 EDT --- The license issue is unfortunately a blocker. Another comment is that, in my opinion, it is better in general to have make variables passed as make arguments and not as shell env variables (though both work with gnu make), like: make install DESTDIR="$RPM_BUILD_ROOT" INSTALL="install -p" Not a blocker. Otherwise I haven't seen anything obviously wrong by glancing at the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review