Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458784 --- Comment #7 from Michal Nowak <mnowak@xxxxxxxxxx> 2008-10-06 05:08:08 EDT --- (In reply to comment #6) > You could use > make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' to keep > header files timestamps. Improved. > > You could do make check in %check. > Done. > rpmlint output is ignorable: > xcb-util-devel.i386: W: no-documentation > > I'd propose a shorter summary: > > Convenience libraries sitting on top of libxcb > > And for the devel summary I propose: > > Development and header files for xcb-util > Both done. > There is a license issue, wm/reply_formats.c notice refers to COPYING > which isn't present. > Probably somewhat more of such problems, see https://bugs.freedesktop.org/show_bug.cgi?id=17078 ... > In rm -rf %{buildroot}%{_libdir}/*.la, the -r is not needed. And the > -f isn't needeed too, I prefer personnally being warned when a file > I had to remove isn't present anymore. Good idea, why not. Done. http://www.stud.fit.vutbr.cz/~xnowak01/Fedora/xcb-util/xcb-util.spec http://www.stud.fit.vutbr.cz/~xnowak01/Fedora/xcb-util/xcb-util-0.3.0-2.el5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review