[Bug 458784] Review Request: xcb-util - The xcb-util module provides a number of libraries which sit on top of libxcb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458784


Michal Nowak <mnowak@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    External Bug ID|                            |FreeDesktop.org 17078




--- Comment #9 from Michal Nowak <mnowak@xxxxxxxxxx>  2008-10-13 04:37:53 EDT ---
(In reply to comment #8)
> The license issue is unfortunately a blocker. 
> 

Sure. Pinged on upstream BZ.

> Another comment is that, in my opinion, it is better in general 
> to have make variables passed as make arguments and not as 
> shell env variables (though both work with gnu make), like:
> 
> make install DESTDIR="$RPM_BUILD_ROOT" INSTALL="install -p"

That sounds reasonable.


* Mon Oct 13 2008 Michal Nowak <mnowak@xxxxxxxxxx> - 0.3.0-3
- move from system env vars to local GNU make ones

http://www.stud.fit.vutbr.cz/~xnowak01/Fedora/xcb-util/xcb-util.spec

http://www.stud.fit.vutbr.cz/~xnowak01/Fedora/xcb-util/xcb-util-0.3.0-2.el5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]