Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461897 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> 2008-10-03 09:19:46 EDT --- > (In reply to comment #1) > > Description probably needs some more love -- the fact > > that the package is free doesn't need to be mentioned there (redundant, see > > License tag) and "X windows" is correctly spelled without the trailing "s" and > > with "w" capitablized: "X Window", "X Window System", or just "X11". > > Yep, sorry for that, I've just copied and pasted it from the author's webpages. Similarly to %description, I suggest you change the Comment= in .desktop file to somthing more sensible (such as "Utility that analyzes the system of lenses" (may apply to Summary as well): Comment=OpticalRayTracer is a free (GPL) Linux (Xwindows GUI-based) utility that analyzes systems of lenses.(In reply to comment #2) This is definitely not a blocker though. > This is now not necessary anymore thanks to fast upstream reaction. Also, my > patch for 64bit systems has been merged and new version released (how nice!:). Thanks for that! > > What's "%{_datadir}/apps"? Would not "%{_datadir}/raytracer" be more > > appropriate? In case not, please ensure you depend on the package that creates > > it or own it. > > %{_datadir}/apps/raytracer/ > > Look like a standard path for KDE apps. It should be ok as opticalraytracer > depends on kdelibs3 which in turn depends on kde-filesystem which owns > %{datadir}/apps. The same applies for %{docdir}/HTML/en where newly some files > are stored too. > > Note: rpmlint is silent on spec file and SRPM, but not on RPMs: > > >rpmlint -i opticalraytracer-1.2-1.fc9.x86_64.rpm > opticalraytracer.x86_64: W: dangling-relative-symlink > /usr/share/doc/HTML/en/raytracer/common ../common > The relative symbolic link points nowhere. > > I don't know whether I can avoid this somehow, the pointed directory is owned > by kdelibs-common which is also a dependency of kdelibs3, hence this shouldn't > be IMHO a problem. That's fine then. The package looks perfect now; thanks and sorry for the delay; APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review