Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458338 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-03 09:31:07 EDT --- Some notes: * Macros - Defining %_prefix is not needed - jobs is not defined on Fedora. Also please support parallel make if possible: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - %distname is not defined. * SourceURL - must be written with full URL. For sourceforge hosted tarball, please refer to https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net * BuildRoot - does not honor Fedora packagig guidelines: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Compilation flags - Fedora specific compilation flags are not correctly honored. You can check what compilation flags are used by $ rpm --eval %optflags https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags - Also compilation flag "-Os" supersedes "-O2" flag in %optflags so please remove this. * Timestamps - When using "cp" or "install" commands, add "-p" option to keep timestamps on installed files. * Desktop file - When using only basename of the icon file is used for Icon entry removing suffix is preferred: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * %clean - The part "[ -d %{buildroot} -a "%{buildroot}" != "" ] && " is not needed * Inconsistent usage of %buildroot vs $RPM_BUILD_ROOT - Please choose one and not use both * %defattr - We recommend to use %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review