Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461897 --- Comment #2 from Milos Jakubicek <xjakub@xxxxxxxxxx> 2008-09-24 13:16:40 EDT --- (In reply to comment #1) > Please remove the leading blank line in %description, I am not sure it would > look well in GUI tools. Done. > Description probably needs some more love -- the fact > that the package is free doesn't need to be mentioned there (redundant, see > License tag) and "X windows" is correctly spelled without the trailing "s" and > with "w" capitablized: "X Window", "X Window System", or just "X11". Yep, sorry for that, I've just copied and pasted it from the author's webpages. > It's not clear what does this line do, and why does it belong to %prep. Please > explain and add a comment: > make -f Makefile.cvs dist This is now not necessary anymore thanks to fast upstream reaction. Also, my patch for 64bit systems has been merged and new version released (how nice!:). > What's "%{_datadir}/apps"? Would not "%{_datadir}/raytracer" be more > appropriate? In case not, please ensure you depend on the package that creates > it or own it. > %{_datadir}/apps/raytracer/ Look like a standard path for KDE apps. It should be ok as opticalraytracer depends on kdelibs3 which in turn depends on kde-filesystem which owns %{datadir}/apps. The same applies for %{docdir}/HTML/en where newly some files are stored too. Note: rpmlint is silent on spec file and SRPM, but not on RPMs: >rpmlint -i opticalraytracer-1.2-1.fc9.x86_64.rpm opticalraytracer.x86_64: W: dangling-relative-symlink /usr/share/doc/HTML/en/raytracer/common ../common The relative symbolic link points nowhere. I don't know whether I can avoid this somehow, the pointed directory is owned by kdelibs-common which is also a dependency of kdelibs3, hence this shouldn't be IMHO a problem. New SPEC file: http://mjakubicek.fedorapeople.org/opticalraytracer/opticalraytracer.spec New SRPM: http://mjakubicek.fedorapeople.org/opticalraytracer/opticalraytracer-1.2-1.fc9.src.rpm (there are also x68_64 RPMs in the same dir) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review