Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461897 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> 2008-09-11 11:27:25 EDT --- Looks very well. Please remove the leading blank line in %description, I am not sure it would look well in GUI tools. Description probably needs some more love -- the fact that the package is free doesn't need to be mentioned there (redundant, see License tag) and "X windows" is correctly spelled without the trailing "s" and with "w" capitablized: "X Window", "X Window System", or just "X11". It's not clear what does this line do, and why does it belong to %prep. Please explain and add a comment: make -f Makefile.cvs dist What's "%{_datadir}/apps"? Would not "%{_datadir}/raytracer" be more appropriate? In case not, please ensure you depend on the package that creates it or own it. %{_datadir}/apps/raytracer/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review