[Bug 463587] Review Request: CWIRC - An X Chat plugin to allow send and receive morse code over IRC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463587





--- Comment #4 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx>  2008-09-28 06:24:37 EDT ---
Please bump the release tag and list here the URL of the new spec + src.rpm
each time you modify the spec. This makes tracking versions easier for everyone


Your idea to use a general function plus a loop to convert the french
documentation to UTF-8 is nice. But replacing two lines of code with a 6 lines
function + a 3 line loop hardly can be seen as an economy :) Anyway, please use
         iconv -f "$2" -t utf-8 < "$1" > "${1}_"
         touch -R "$1" "${1}_"
         mv -f "${1}_" "$1"
thus preserving the timestamp of the original file.

We still have one problem: the debuginfo that is generated is empty. I am also
certain that the culprit are the two "strip " lines from the end of the build:
  gcc -shared -lm  -o cwirc.so plugin.shared.o ipc.shared.o grid.shared.o
propagation.shared.o cwframe.shared.o
  strip cwirc.so
  gcc -lm  `pkg-config --libs gtk+-2.0` -o cwirc_frontend frontend.o io.o gui.o
ipc.o keyer.o grid.o propagation
.o cwsound.o cwdecoder.o cwframe.o rcfile.o extension.o
  strip cwirc_frontend
  + exit 0

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]