Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464402 Marek Mahut <mmahut@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Marek Mahut <mmahut@xxxxxxxxxx> 2008-09-28 05:20:02 EDT --- + package meets naming and versioning guidelines + specfile is properly named, is cleanly written and uses macros consistently + dist tag is present. + license field matches the actual license + license is open source-compatible + license text not included upstream + %clean is present. + package builds in mock (f8, rawhide) + package installs properly (f8) + rpmlint output is sane + desktop file install properly - use %doc to include documentation - SDL-devel dependency is fetched by SDL_image-devel, it's safe to remove - desktop file is not (fully) valid: ./numptyphysics.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review