Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling Alias: perl-RPC-XML https://bugzilla.redhat.com/show_bug.cgi?id=435835 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2008-07-03 19:22 EST ------- (In reply to comment #8) > - I guess you need to add the testsuite to %check in the spec, but I do not > really know anything, because I did not read anything about testsuites in any > Fedora guideline, but only in some reviews that there was no need for %check, > because there was no testsuite. Test suites _must_ be run for perl packages; see: http://fedoraproject.org/wiki/Packaging/Perl#Testing_and_Test_Suites I like the splitting of the Apache bits off into their own sub-package :) The %files section should be amended so the correct package owns %{perl_vendorlib}/Apache and %{perl_vendorlib}/RPC. See http://fedoraproject.org/wiki/Packaging/Perl#Directory_Ownership Your license shortname is off, and missing the LGPL :) See http://fedoraproject.org/wiki/Licensing#Good_Licenses There appear to be some samples/docs under the etc/, ex/ and methods/ directories. It may be worthwhile to include them in %doc. Do these things, and (from my cursory scan of the spec) I believe this package will be ready for a review :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review