Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling Alias: perl-RPC-XML https://bugzilla.redhat.com/show_bug.cgi?id=435835 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx ------- Additional Comments From opensource@xxxxxxxxx 2008-06-16 18:23 EST ------- two minor issues: - imho you should add "-p" to the %{__cp} of Source1 to preserve the timestamp - You should add README.license to %doc of the main package, otherwise there is no need to cp it ;-) maybe one major issue: - I guess you need to add the testsuite to %check in the spec, but I do not really know anything, because I did not read anything about testsuites in any Fedora guideline, but only in some reviews that there was no need for %check, because there was no testsuite. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review