Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling Alias: perl-RPC-XML https://bugzilla.redhat.com/show_bug.cgi?id=435835 ------- Additional Comments From nsboyle@xxxxxxxxx 2008-06-05 22:06 EST ------- Sorry for the long delay in getting these issues fixed: New version: Spec URL: http://nboyle.fedorapeople.org/perl-RPC-XML.spec SRPM URL: http://nboyle.fedorapeople.org/perl-RPC-XML-0.59-5.fc8.src.rpm (In reply to comment #6) > There's a test suite included; any reason why it's not being run? Of course, > when you do run it, you'll find out why Chris was telling you about missing > build dependencies, because most of the tests will fail without Test::More and > XML::Parser. Note that pretty much any reviewer will consider it a blocker to > fail to run the test suite without a good reason. Chalk this up to my inexperience with packaging Perl modules. I didn't realize this module had a unit tests with it... I've since added both missing build dependencies. > Also, is there any particular reason why you didn't just use cpanspec to > generate the package? While there's nothing specifically wrong with rolling > your own by hand, it's a good but more difficult to review since it doesn't look > anything like essentially all of the other Perl packages in the distro. Again, inexperience (you've got to start somewhere though, right?). I wasn't even aware of such a tool. I had originally adopted this spec from Dries, although admittedly by this point it's almost a complete rewrite. My thoughts are that at this point, it's best to just leave it as-is and keep this tool in mind for future packagings. If it still makes more sense to redo it using cpanspec, I'll gladly do that. Let me know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review