https://bugzilla.redhat.com/show_bug.cgi?id=2335839 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks! There are some differences from the spec file generated by rust2rpm that I don't understand: -Name: rust-async-std-resolver +Name: rust-%{crate} Why change this? While this is equivalent, I wouldn't recommend changing anything that rust2rpm generates, just because you'd need to re-do those changes on any version updates when re-generating the spec file. -Summary: Hickory DNS is a safe and secure DNS library, for async-std +Summary: A library implementing the DNS resolver using the Hickory DNS Resolver library The second one is, IMO, worse, though both are not good. "A library implementing (...)" is more or less only fluff - Summary tags should not start with "A" or "An", and it's clear that this is a library from the package type. I would suggest using "Summary: DNS resolver implementation based on async-std and Hickory DNS" or something like that. You can override this with a rust2rpm.toml setting so you don't have to re-apply this change with every update. Similarly, for the %description - though why change it at all? The generated one seems fine. -%bcond check 1 +%bcond_with check If this spec was generated by rust2rpm v27, why is there the old bcond syntax? Just swap 1 for 0 to disable tests, no need to go back to ancient times :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2335839 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335839%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
