https://bugzilla.redhat.com/show_bug.cgi?id=2329142 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks, looks mostly good to me, with two small caveats: - Can you add comments to the spec file for what you're patching? Something like this would be enough: """ # * drop unused sct feature / tls_codec dependency # * bump rstest dev-dependency from 0.18 to 0.23 """ - There's some amount of test data that aren't useful in the built package. You could exclude it by adding the following to the "%files devel" list: """ %exclude %{crate_instdir}/tests/examples/ """ Both (and the Summary override) could be automated with a rust2rpm.toml config snippet: """ [package] summary = "Pure Rust implementation of the X.509 PKI Certificate format from RFC 5280" cargo-toml-patch-comments = [ "drop unused sct feature / tls_codec dependency", "bump rstest dev-dependency from 0.18 to 0.23", ] exclude-crate-files = [ "tests/examples/", ] """ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2329142 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329142%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
