https://bugzilla.redhat.com/show_bug.cgi?id=2335839 --- Comment #6 from Umut Demir <umutd3401@xxxxxxxxxx> --- Thanks for the review! (In reply to Fabio Valentini from comment #5) > Why change this? While this is equivalent, I wouldn't recommend changing > anything that rust2rpm generates, just because you'd need to re-do those > changes on any version updates when re-generating the spec file. > If this spec was generated by rust2rpm v27, why is there the old bcond > syntax? Just swap 1 for 0 to disable tests, no need to go back to ancient > times :) I will be careful not to change anything unless necessary, thank you. > The second one is, IMO, worse, though both are not good. > "A library implementing (...)" is more or less only fluff - Summary tags > should not start with "A" or "An", and it's clear that this is a library > from the package type. > > I would suggest using "Summary: DNS resolver implementation based on > async-std and Hickory DNS" or something like that. Done. The packaging guidelines show an example that starts with an "A" as a good practice, so I thought it was acceptable. > Similarly, for the %description - though why change it at all? The generated > one seems fine. Some other crates related to Hickory DNS also start like that. I just didn't want to make them all same and wanted to provide information about the package itself more. It is not necessary to do this, of course. Changed it. Spec URL: https://download.copr.fedorainfracloud.org/results/umutd3401/test-builds/fedora-rawhide-x86_64/08578602-rust-async-std-resolver/rust-async-std-resolver.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/umutd3401/test-builds/fedora-rawhide-x86_64/08578602-rust-async-std-resolver/rust-async-std-resolver-0.24.2-1.fc42.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2335839 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335839%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
