https://bugzilla.redhat.com/show_bug.cgi?id=2339108 Ondřej Budai <obudai@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Ondřej Budai <obudai@xxxxxxxxxx> --- I think that some build requirements can be pruned, specifically these ones: BuildRequires: systemd BuildRequires: krb5-devel BuildRequires: python3-docutils BuildRequires: make BuildRequires: systemd-rpm-macros BuildRequires: git If the git one cannot be removed, then you should at least make an attempt to reduce it to git-core, see https://fedoraproject.org/wiki/Changes/ChangeToGitCore --- %bcond_with tests %bcond_with relax_requires don't seem to be used, just copy-paste artifacts from osbuild-composer. --- ExcludeArch: armv7hl is no longer needed, it was retired in F37, see https://fedoraproject.org/wiki/Changes/RetireARMv7 --- Would be nice to switch to go-vendor-tools to align this with the rest of Fedora Go bundled RPMs. This is not mandated at this point, thus I will not block on it. --- Source0 should be a full URL, otherwise please document how to generate the tarball. --- A man page would be nice. This is not mandated, but highly recommended. I will not block on it. Cobra can generate the skeleton btw. Also, bash/zsh/fish completions would be nice (I have no experience packaging this, though. :( ) --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4659 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. Builds just fine. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: image-builder-6-1.20250121104637388188.main.1.g54d9ab4.fc42.x86_64.rpm image-builder-6-1.20250121104637388188.main.1.g54d9ab4.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9132f0pl')] checks: 32, packages: 2 image-builder.src: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build') image-builder.src: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build') image-builder.x86_64: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build') image-builder.x86_64: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build') image-builder.x86_64: W: no-manual-page-for-binary image-builder image-builder.spec: W: invalid-url Source0: image-builder-cli-6.tar.gz 2 packages and 0 specfiles checked; 4 errors, 2 warnings, 7 filtered, 4 badness; has taken 0.7 s Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "image-builder-debuginfo". (none): E: there is no installed rpm "image-builder". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- image-builder (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libgpgme.so.11()(64bit) libgpgme.so.11(GPGME_1.0)(64bit) libgpgme.so.11(GPGME_1.1)(64bit) libresolv.so.2()(64bit) osbuild osbuild-depsolve-dnf osbuild-luks2 osbuild-lvm2 osbuild-ostree rtld(GNU_HASH) Provides -------- image-builder: bundled(golang(dario.cat/mergo)) bundled(golang(github.com/BurntSushi/toml)) bundled(golang(github.com/Microsoft/go-winio)) bundled(golang(github.com/Microsoft/hcsshim)) bundled(golang(github.com/VividCortex/ewma)) bundled(golang(github.com/acarl005/stripansi)) bundled(golang(github.com/asaskevich/govalidator)) bundled(golang(github.com/containerd/cgroups/v3)) bundled(golang(github.com/containerd/errdefs)) bundled(golang(github.com/containerd/stargz-snapshotter/estargz)) bundled(golang(github.com/containers/common)) bundled(golang(github.com/containers/image/v5)) bundled(golang(github.com/containers/libtrust)) bundled(golang(github.com/containers/ocicrypt)) bundled(golang(github.com/containers/storage)) bundled(golang(github.com/cyberphone/json-canonicalization)) bundled(golang(github.com/cyphar/filepath-securejoin)) bundled(golang(github.com/davecgh/go-spew)) bundled(golang(github.com/distribution/reference)) bundled(golang(github.com/docker/distribution)) bundled(golang(github.com/docker/docker)) bundled(golang(github.com/docker/docker-credential-helpers)) bundled(golang(github.com/docker/go-connections)) bundled(golang(github.com/docker/go-units)) bundled(golang(github.com/felixge/httpsnoop)) bundled(golang(github.com/go-jose/go-jose/v4)) bundled(golang(github.com/go-logr/logr)) bundled(golang(github.com/go-logr/stdr)) bundled(golang(github.com/go-openapi/analysis)) bundled(golang(github.com/go-openapi/errors)) bundled(golang(github.com/go-openapi/jsonpointer)) bundled(golang(github.com/go-openapi/jsonreference)) bundled(golang(github.com/go-openapi/loads)) bundled(golang(github.com/go-openapi/runtime)) bundled(golang(github.com/go-openapi/spec)) bundled(golang(github.com/go-openapi/strfmt)) bundled(golang(github.com/go-openapi/swag)) bundled(golang(github.com/go-openapi/validate)) bundled(golang(github.com/gobwas/glob)) bundled(golang(github.com/gogo/protobuf)) bundled(golang(github.com/golang/groupcache)) bundled(golang(github.com/golang/protobuf)) bundled(golang(github.com/google/go-containerregistry)) bundled(golang(github.com/google/go-intervals)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/gorilla/mux)) bundled(golang(github.com/hashicorp/errwrap)) bundled(golang(github.com/hashicorp/go-multierror)) bundled(golang(github.com/hashicorp/go-version)) bundled(golang(github.com/inconshreveable/mousetrap)) bundled(golang(github.com/josharian/intern)) bundled(golang(github.com/json-iterator/go)) bundled(golang(github.com/klauspost/compress)) bundled(golang(github.com/klauspost/pgzip)) bundled(golang(github.com/letsencrypt/boulder)) bundled(golang(github.com/mailru/easyjson)) bundled(golang(github.com/mattn/go-runewidth)) bundled(golang(github.com/mattn/go-sqlite3)) bundled(golang(github.com/miekg/pkcs11)) bundled(golang(github.com/mistifyio/go-zfs/v3)) bundled(golang(github.com/mitchellh/mapstructure)) bundled(golang(github.com/moby/docker-image-spec)) bundled(golang(github.com/moby/sys/mountinfo)) bundled(golang(github.com/moby/sys/user)) bundled(golang(github.com/modern-go/concurrent)) bundled(golang(github.com/modern-go/reflect2)) bundled(golang(github.com/oklog/ulid)) bundled(golang(github.com/opencontainers/go-digest)) bundled(golang(github.com/opencontainers/image-spec)) bundled(golang(github.com/opencontainers/runtime-spec)) bundled(golang(github.com/opencontainers/selinux)) bundled(golang(github.com/osbuild/images)) bundled(golang(github.com/ostreedev/ostree-go)) bundled(golang(github.com/pkg/errors)) bundled(golang(github.com/pmezard/go-difflib)) bundled(golang(github.com/proglottis/gpgme)) bundled(golang(github.com/rivo/uniseg)) bundled(golang(github.com/secure-systems-lab/go-securesystemslib)) bundled(golang(github.com/sigstore/fulcio)) bundled(golang(github.com/sigstore/rekor)) bundled(golang(github.com/sigstore/sigstore)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/spf13/cobra)) bundled(golang(github.com/spf13/pflag)) bundled(golang(github.com/stefanberger/go-pkcs11uri)) bundled(golang(github.com/stretchr/testify)) bundled(golang(github.com/sylabs/sif/v2)) bundled(golang(github.com/syndtr/gocapability)) bundled(golang(github.com/tchap/go-patricia/v2)) bundled(golang(github.com/titanous/rocacheck)) bundled(golang(github.com/ulikunitz/xz)) bundled(golang(github.com/vbatts/tar-split)) bundled(golang(github.com/vbauerster/mpb/v8)) bundled(golang(go.mongodb.org/mongo-driver)) bundled(golang(go.mozilla.org/pkcs7)) bundled(golang(go.opencensus.io)) bundled(golang(go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp)) bundled(golang(go.opentelemetry.io/otel)) bundled(golang(go.opentelemetry.io/otel/metric)) bundled(golang(go.opentelemetry.io/otel/trace)) bundled(golang(golang.org/x/crypto)) bundled(golang(golang.org/x/exp)) bundled(golang(golang.org/x/net)) bundled(golang(golang.org/x/sync)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/term)) bundled(golang(golang.org/x/text)) bundled(golang(google.golang.org/genproto/googleapis/rpc)) bundled(golang(google.golang.org/grpc)) bundled(golang(google.golang.org/protobuf)) bundled(golang(gopkg.in/ini.v1)) bundled(golang(gopkg.in/yaml.v3)) image-builder image-builder(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name image-builder --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, R, Ocaml, Haskell, Perl, SugarActivity, C/C++, Java, fonts, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2339108 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202339108%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
