https://bugzilla.redhat.com/show_bug.cgi?id=2339108 Simon de Vlieger <cmdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(obudai@xxxxxxxxxx | |) --- Comment #3 from Simon de Vlieger <cmdr@xxxxxxxxxxxx> --- @obudai@xxxxxxxxxx thank you for the review! Let me start off with the URLs to a new specfile and srpm: Spec: https://supakeen.fedorapeople.org/for-review/image-builder.spec SRPM: https://supakeen.fedorapeople.org/for-review/image-builder-8-1.20250122git5047b2c.fc41.src.rpm I've addressed: 1. Removed the unused `bcond`s. 2. Removed the armv7hl excludearch. 3. Removed the unused buildrequires. As for the other issues: 1. Source0 was filled in by COPR, it is normally %{gosource} so I don't directly control the URL that ends up there. What would you like me to write to make this clear in the specfile? 2. I will provide a manpage as soon as the upstream has slightly more proper documentation. 3. go-vendor-tools is on the tryout list, I've initially only used the license generation here but we do want to fit it into our workflow (later). Let me know if you need anything else! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2339108 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202339108%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
