https://bugzilla.redhat.com/show_bug.cgi?id=2338412 --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #3) > Some drive-by comments: > > BuildRequires: chrpath > > Looks unused. Build log shows no calls to chrpath. Fixed, leftover from previous version. > > Provides: bundled(miniz) = 1.15 > > Would it be feasible to unbundle miniz? Nope, version 1.15, any version or fork is not compatible. > The code licenses should be verified and tag updated. Fixed, checked each file. (In reply to Neal Gompa from comment #4) > > %{_mandir}/man3/IMG_*.3* > > This needs to be brought up with upstream to correctly prefix it. Otherwise > there's a risk of collisions. At the moment `dnf provides /usr/share/man3/IMG_*` yields nothing. The man pages are autogenerated from the cmake/sdlmanpages.cmake file, and historically instead of man pages they autogenerate the documentation for the wiki, hosted here: https://wiki.libsdl.org/SDL3_image/CategoryAPI To be honest I would not change them, worst case we disable the man pages. In SDL2 the documentation was generated only for the Wiki. Spec URL: https://slaanesh.fedorapeople.org/review/SDL3_image.spec SRPM URL: https://slaanesh.fedorapeople.org/review/SDL3_image-3.1.0-1.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2338412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338412%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
