https://bugzilla.redhat.com/show_bug.cgi?id=2326979 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I agree, the changes made to the package look strange. The patch does some things that I would classify as "suspicious": 1. Bumping the bitflags dependency from ^1.2 to ^1.3 - this looks like a misunderstanding of what `version = "1.2"` means (it means "1.2 or any version compatible with it, i.e. <2.0", which includes 1.3.x) 2. Removing the dependencies for the "generate" and "jwt-convert" features, but not the features themselves is wrong. If these features should not be available in the packaged crate, just dropping the dependencies but not the features themselves will have unintentional consequences (for example, the subpackages for these features will still be generated in the .spec file). 3. Moving "num-bigint" and "yasna" into "named dependencies" (i.e. "dep:num-bigint" and "dep:yasna") is an unnecessary divergence from the upstream crate metadata, and could lead to problems with dependent crates which could expect the implicitly defined features for "num-bigint" and "yasna" to be present. 4. Setting `%global cargo_install_bin 0` is a noop, this crate does not contain any executables. I don't know where you got this from, but it is useless here. 5. Do not drop the rust-%{crate}-$feature-devel subpackages from the generated spec file manually. They are there for a reason, and they MUST match cargo metadata to avoid build failures or unexpected problems in packages for dependent crates. In particular, dropping the subpackage for the "default" feature is problematic. The "default" feature is unconditionally defined by cargo even if it is not explicitly mentioned in crate metadata. In general, I would recommend not to make any changes to the spec file generated by rust2rpm unless you are *sure* that they are correct and necessary. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2326979 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202326979%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
