https://bugzilla.redhat.com/show_bug.cgi?id=2326979 Uri Lublin <uril@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(uril@xxxxxxxxxx) | --- Comment #4 from Uri Lublin <uril@xxxxxxxxxx> --- (In reply to Cole Robinson from comment #2) Cole, thank you for reviewing. > So I attempted to reproduce spec with rust2rpm on fedora40 host. After doing > the dance of applying the patch diff interactively, here's the diff in the > spec file output: <rust-jsonwebkey.spec diff dropped> > Were those latter bits manually deleted? Or did I miss something in the > invocation? The spec file was created with rust2rpm.toml: -------------- [package] cargo-install-bin = false cargo-install-lib = true [features] hide = ["generate", "jwt-convert", "default"] -------------- Next time I'll add the rust2rpm.toml as a comment/attachment. > Notably it seemed odd to me that `-n %{name}+default-devel` subpackage was > missing > since that seems to be in every rust crate I've looked at (but maybe I'm > missing something). All the "features" except for "pkcs-convert" are "hidden". I'll "unhide" the "default" feature. > > I think it would also be helpful to enumerate in the `Patch:` comment what > deps were tweaked. Like 'adjust version for crate FOO and BAR to match > Fedora. drop BAZ and WIBBLE which aren't packaged. drop all deps for BLAH > feature which we don't need' or something to that effect. Yeah, I'll add such comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2326979 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202326979%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
