https://bugzilla.redhat.com/show_bug.cgi?id=2326979 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |needinfo?(uril@xxxxxxxxxx) CC| |crobinso@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx --- Comment #2 from Cole Robinson <crobinso@xxxxxxxxxx> --- So I attempted to reproduce spec with rust2rpm on fedora40 host. After doing the dance of applying the patch diff interactively, here's the diff in the spec file output: ``` --- rust-jsonwebkey.spec 2024-11-26 15:38:57.277635956 -0500 +++ bak 2024-11-26 15:26:49.190513593 -0500 @@ -2,6 +2,9 @@ %bcond_without check %global debug_package %{nil} +# prevent executables from being installed +%global cargo_install_bin 0 + %global crate jsonwebkey Name: rust-jsonwebkey @@ -15,7 +18,7 @@ Source: %{crates_source} # Manually created patch for downstream crate metadata changes Patch: jsonwebkey-fix-metadata.diff -BuildRequires: cargo-rpm-macros >= 24 +BuildRequires: cargo-rpm-macros >= 26 %global _description %{expand: JSON Web Key (JWK) (de)serialization, generation, and conversion.} @@ -36,42 +39,6 @@ use the "%{crate}" crate. %doc %{crate_instdir}/README.md %{crate_instdir}/ -%package -n %{name}+default-devel -Summary: %{summary} -BuildArch: noarch - -%description -n %{name}+default-devel %{_description} - -This package contains library source intended for building other packages which -use the "default" feature of the "%{crate}" crate. - -%files -n %{name}+default-devel -%ghost %{crate_instdir}/Cargo.toml - -%package -n %{name}+generate-devel -Summary: %{summary} -BuildArch: noarch - -%description -n %{name}+generate-devel %{_description} - -This package contains library source intended for building other packages which -use the "generate" feature of the "%{crate}" crate. - -%files -n %{name}+generate-devel -%ghost %{crate_instdir}/Cargo.toml - -%package -n %{name}+jwt-convert-devel -Summary: %{summary} -BuildArch: noarch - -%description -n %{name}+jwt-convert-devel %{_description} - -This package contains library source intended for building other packages which -use the "jwt-convert" feature of the "%{crate}" crate. - -%files -n %{name}+jwt-convert-devel -%ghost %{crate_instdir}/Cargo.toml - %package -n %{name}+pkcs-convert-devel Summary: %{summary} BuildArch: noarch ``` Were those latter bits manually deleted? Or did I miss something in the invocation? Notably it seemed odd to me that `-n %{name}+default-devel` subpackage was missing since that seems to be in every rust crate I've looked at (but maybe I'm missing something). I think it would also be helpful to enumerate in the `Patch:` comment what deps were tweaked. Like 'adjust version for crate FOO and BAR to match Fedora. drop BAZ and WIBBLE which aren't packaged. drop all deps for BLAH feature which we don't need' or something to that effect. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2326979 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202326979%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
