https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #15 from Kalev Lember <klember@xxxxxxxxxx> --- I think you misunderstand a bit what's going on here. First, the %check bcond is used when generating rust crate buildrequires and it needs to be there so that the buildrequires generator correctly pulls in rust crates that are required for tests. I assume you have not seen this before because you've worked in RHEL context where rust dependencies are bundled and cargo depgen is not used. The bcond has to be named 'check' because of that. Second, the %check bcond wrapping the %check section is common pattern in rust crates. I assume you've not seen this either because in RHEL the crates are bundled. See any random rust- package, e.g. https://src.fedoraproject.org/rpms/rust-gst-plugin-reqwest/blob/rawhide/f/rust-gst-plugin-reqwest.spec Third, the %check bcond as it is now in the spec file is *enabled* and it is only there to be able to build tests - I have no intention of disabling it. Again, it is there to be *able* to run tests, not to disable them. All the guidelines mentions you have above are not at all relevant because these are all run as per the guidelines. Fourth, in the case of a hypothetical bootstrapping of a new architecture (think RISC V) it can be beneficial to have a way to disable self tests for initial bootstrapping. Completely wrapping the %check section in the %check bcond makes this easily possible. Again, this is not for main Fedora - it just makes it easier for other parties. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
