https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Debarshi Ray <debarshir@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |debarshir@xxxxxxxxxx --- Comment #16 from Debarshi Ray <debarshir@xxxxxxxxxx> --- A fly-by comment from someone who knows absolutely nothing about Rust or how to package anything written in it. (In reply to Kalev Lember from comment #15) > Second, the %check bcond wrapping the %check section is common pattern in > rust crates. I assume you've not seen this either because in RHEL the crates > are bundled. See any random rust- package, e.g. > https://src.fedoraproject.org/rpms/rust-gst-plugin-reqwest/blob/rawhide/f/ > rust-gst-plugin-reqwest.spec This is also the pattern that go2rpm uses. For example, here are some RPMs that I recently added to Fedora: https://src.fedoraproject.org/rpms/golang-github-nvidia-nvml/blob/rawhide/f/golang-github-nvidia-nvml.spec https://src.fedoraproject.org/rpms/golang-github-nvidia-nvlib/blob/rawhide/f/golang-github-nvidia-nvlib.spec https://src.fedoraproject.org/rpms/golang-github-nvidia-container-toolkit/blob/rawhide/f/golang-github-nvidia-container-toolkit.spec https://src.fedoraproject.org/rpms/golang-tags-cncf-container-device-interface/blob/rawhide/f/golang-tags-cncf-container-device-interface.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
