https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #14 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- (In reply to Kalev Lember from comment #11) > > Only `%meson_test` should be conditional on `%if %{with check}`, but the desktop-file-validate and appstream-util commands should be run regardless. Also, if I'm not mistaken, all the .metainfo.xml files need to be verified, not just the app's. > > Why do you think so? For me, when I see a conditional that reads `%if %{with > check}`, that sounds like something that would disable the whole check > section, not just some part of it. * Tests are usually disabled because of extra dependencies, flakiness, or other requirements that cannot be fulfilled (e.g. network access). None of those reasons apply to these validations. * Validation of these files can occur in either %install or %check. * Validation of these files is a MUST: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ * The conditional can be named "tests" instead of "check" if you feel that is less ambiguous; tests may be more common anyway (outside of Rust crates). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
