https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #10 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- Thanks; as the directory ownership issues properly belong in filesystem, I don't think they should block this. License needs a fix: -License: GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND libtiff AND (MIT OR Apache-2.0) AND Unicode-DFS-2016 AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0) AND (Unlicense OR MIT) +License: GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND libtiff AND ((MIT OR Apache-2.0) AND Unicode-DFS-2016) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (Unlicense OR MIT) Only `%meson_test` should be conditional on `%if %{with check}`, but the desktop-file-validate and appstream-util commands should be run regardless. Also, if I'm not mistaken, all the .metainfo.xml files need to be verified, not just the app's. In `%files libs`, this is safer and conformant with the guidelines (e.g. if .so.5 were to suddenly become .so.50 or .so.500): -%{_libdir}/libppsdocument-4.0.so.5* -%{_libdir}/libppsview-4.0.so.4* +%{_libdir}/libppsdocument-4.0.so.5{,.*} +%{_libdir}/libppsview-4.0.so.4{,.*} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
