https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #11 from Kalev Lember <klember@xxxxxxxxxx> --- > Only `%meson_test` should be conditional on `%if %{with check}`, but the desktop-file-validate and appstream-util commands should be run regardless. Also, if I'm not mistaken, all the .metainfo.xml files need to be verified, not just the app's. Why do you think so? For me, when I see a conditional that reads `%if %{with check}`, that sounds like something that would disable the whole check section, not just some part of it. I've applied the rest of the suggestions - thanks! Spec URL: https://kalev.fedorapeople.org/papers.spec SRPM URL: https://kalev.fedorapeople.org/papers-47~beta-5.fc42.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123303870 * Thu Sep 12 2024 Kalev Lember <klember@xxxxxxxxxx> - 47~beta-5 - Use globs to ensure all desktop and metainfo files get validated * Thu Sep 12 2024 Kalev Lember <klember@xxxxxxxxxx> - 47~beta-4 - Tighten soname globs * Thu Sep 12 2024 Kalev Lember <klember@xxxxxxxxxx> - 47~beta-3 - Remove duplicate '(MIT OR Apache-2.0)' from license tag -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
