https://bugzilla.redhat.com/show_bug.cgi?id=2310345 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jplesnik@xxxxxxxxxx --- Comment #5 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- URL and Source0 FIX: Please switch URL and Source0 from search.cpan.org/cpan.org to metacpan.org BuildRequires FIX: Please add build-require coreutils - needed for macro %{_fixperms} perl(Config) - t/00_diag.t:2 perl-interpreter - perl-Alien-OpenSSL.spec:42 perl-generators - it will automatically generates run-time Requires and Provides for installed Perl files More info about BR https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_build_dependencies FIX: Use 'perl(:VERSION) >= 5.6' instead of 'perl >= 0:5.006' because the package has an epoch. 'perl' is meta-package and it install all core modules and they are not needed for the build. FIX: Remove perl(Sort::Versions) it is not used in the code. TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 then you can remove deleting by find command FIX: Please remove files alienfile, author.yml, dist.ini, META.json they do not needed to be in package $ rpm -qp --requires perl-Alien-OpenSSL-0.15-1.fc42.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Alien::Base) 1 perl(Alien::Base) >= 0.038 1 perl(Alien::OpenSSL) 2 perl(base) 1 perl-libs 2 perl(strict) 2 perl(warnings) 1 pkgconfig(openssl) = 3.2.2 FIX: Do not list run-requires, they will be generates by perl-generators $ rpm -qp --provides perl-Alien-OpenSSL-0.15-1.fc42.x86_64.rpm | sort | uniq -c 1 perl(Alien::OpenSSL) = 0.15 1 perl-Alien-OpenSSL = 0.15-1.fc42 1 perl(Alien::OpenSSL::Install::Files) 1 perl-Alien-OpenSSL(x86-64) = 0.15-1.fc42 Binary provides are Ok. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2310345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310345%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
