https://bugzilla.redhat.com/show_bug.cgi?id=2310345 Orion Poplawski <orion@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(orion@xxxxxxxx) | --- Comment #6 from Orion Poplawski <orion@xxxxxxxx> --- (In reply to Jitka Plesnikova from comment #5) > URL and Source0 > FIX: Please switch URL and Source0 from search.cpan.org/cpan.org to > metacpan.org Done > BuildRequires > FIX: Please add build-require > coreutils - needed for macro %{_fixperms} Added > perl(Config) - t/00_diag.t:2 > perl-interpreter - perl-Alien-OpenSSL.spec:42 Aren't these brought in by "perl"? > perl-generators - it will automatically generates run-time Requires and > Provides for installed Perl files Added > More info about BR > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ > #_build_dependencies > FIX: Use 'perl(:VERSION) >= 5.6' instead of 'perl >= 0:5.006' because > the package has an epoch. 'perl' is meta-package and it install all > core modules and they are not needed for the build. Done > FIX: Remove perl(Sort::Versions) it is not used in the code. > Done > TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' > If you use option NO_PACKLIST=1, please add version constrain > to ExtUtils::MakeMaker >= 6.76 > then you can remove deleting by find command Done > > FIX: Please remove files alienfile, author.yml, dist.ini, META.json they do > not needed to be in package > > $ rpm -qp --requires perl-Alien-OpenSSL-0.15-1.fc42.x86_64.rpm | sort | uniq > -c | grep -v rpmlib > 1 perl(Alien::Base) > 1 perl(Alien::Base) >= 0.038 > 1 perl(Alien::OpenSSL) > 2 perl(base) > 1 perl-libs > 2 perl(strict) > 2 perl(warnings) > 1 pkgconfig(openssl) = 3.2.2 > FIX: Do not list run-requires, they will be generates by perl-generators Done Sorry for the out of date perl package - it's been a while since I've made one from scratch and it seems that cpanspec is no longer up to date. Spec URL: https://orion.fedorapeople.org/perl-Alien-OpenSSL.spec SRPM URL: https://orion.fedorapeople.org/perl-Alien-OpenSSL-0.15-1.fc42.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2310345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310345%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
