https://bugzilla.redhat.com/show_bug.cgi?id=2283681 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two issues I see so far: 1. The latest version is 0.16.1, you're packaging 0.15.6. Is this intentional? 2. The Cargo.toml patch looks wrong. This crate supports both approx 0.4 and 0.5, bumping the un-versioned dependency from 0.4 to 0.5 just makes both features identical. ``` [dependencies.approx] version = "0.4" optional = true default-features = false [dependencies.approx-0_5] version = "0.5" optional = true default-features = false package = "approx" ``` I would recommend to remove the "approx" *and* "approx-0_5" features (and the "docs" feature that depends on these) instead, and bump only the remaining dev-dependency from 0.4 to 0.5. That is, unless what you're working on explicitly depends on either the ndarray/approx or ndarray/approx-0_5 features. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2283681 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283681%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
